Matthias Clasen [Mon, 18 Jan 2016 05:29:29 +0000 (00:29 -0500)]
Add CSS node tests for checkbutton rtl flipping
Matthias Clasen [Mon, 18 Jan 2016 05:24:53 +0000 (00:24 -0500)]
Add css node tests for expander rtl flipping
Matthias Clasen [Mon, 18 Jan 2016 05:19:31 +0000 (00:19 -0500)]
expander: Flip the alignment of the vertical box
To ensure that the title moves to the other side as expected
in RTL, use GTK_ALIGN_START/END instead of GTK_ALIGN_FILL
when packing the title gadget into the vertical box, and
flip the alignment when the text direction changes.
Matthias Clasen [Mon, 18 Jan 2016 05:11:54 +0000 (00:11 -0500)]
expander: Handle rtl changes again
Now that the box gadget has api for it, use it here to
change the order of the gadgets for right-to-left.
Matthias Clasen [Mon, 18 Jan 2016 05:04:23 +0000 (00:04 -0500)]
checkbutton: Handle rtl changes again
Now that the box gadget has api for it, use it here to
change the order of the gadgets for right-to-left.
Matthias Clasen [Mon, 18 Jan 2016 05:03:39 +0000 (00:03 -0500)]
box gadget: Add a function to reverse children
This can be used to handle text direction changes.
Benjamin Otte [Mon, 18 Jan 2016 04:04:12 +0000 (05:04 +0100)]
reftests: Fix up for easy CSS changes
This is mostly search and replace ala
GtkButton => button
GtkWindow => window
.button => button
or removing style properties that aren't used anymore like
-GtkButton-default-border: 0
Benjamin Otte [Mon, 18 Jan 2016 01:32:19 +0000 (02:32 +0100)]
reftests: Remove test
We no longer match subtypes, so remove the test for it.
Matthias Clasen [Mon, 18 Jan 2016 02:16:33 +0000 (21:16 -0500)]
checkbutton: Use a box gadget
Now that builtin icons have a baseline, we can just use
a box gadget with baseline alignment for the indicator
and the label.
Matthias Clasen [Mon, 18 Jan 2016 02:02:18 +0000 (21:02 -0500)]
builtin icon: set a baseline
Most uses of builtin icons (check and radio buttons,
expanders, etc) are placed next to labels, so they should
be properly positioned wrt to the baseline. Lacking anything
better, give the builtin icons a baseline that places the
center of the icon at the strikethrough position.
Matthias Clasen [Mon, 18 Jan 2016 00:48:40 +0000 (19:48 -0500)]
box gadget: Deal with optional arguments
The baseline arguments to the preferred size callback can
be NULL. Don't crash if they are.
Matthias Clasen [Sun, 17 Jan 2016 20:35:14 +0000 (15:35 -0500)]
Trivial formatting fix
Matthias Clasen [Sun, 17 Jan 2016 20:26:14 +0000 (15:26 -0500)]
Document restrictions on gtk_style_context_get
This makes it official that passing a different state
is not generally supported in the getters for CSS properties.
Matthias Clasen [Sun, 17 Jan 2016 19:35:58 +0000 (14:35 -0500)]
notebook: show tabs when asked to
gtk_notebook_set_show_tabs must make the header gadget
visible when show_tabs is TRUE, not the other way around.
https://bugzilla.gnome.org/show_bug.cgi?id=760596
Matthias Clasen [Sun, 17 Jan 2016 19:08:22 +0000 (14:08 -0500)]
accel label: Fix RTL handling
The 'mad hack' that GtkAccelLabel used to affect the GtkLabel
draw function broke with the introduction of gadgets, since
the positioning is no longer relative to the widgets' allocation
at the time of the call, but rather to the gadgets allocation.
Instead of coming up with an even madder hack to keep this
working, give the GtkLabel draw function knowledge about accel
labels.
https://bugzilla.gnome.org/show_bug.cgi?id=760663
Matthias Clasen [Sun, 17 Jan 2016 18:23:49 +0000 (13:23 -0500)]
inspector: Make cursor-size combo wider
Cursor sizes typically have 2 digits, lets not clip them.
Matthias Clasen [Sun, 17 Jan 2016 17:13:59 +0000 (12:13 -0500)]
Expand window style class documentation a bit
Matthias Clasen [Sat, 16 Jan 2016 18:24:56 +0000 (13:24 -0500)]
Adwaita: Keep entry progress visible
When the entry is focused, make the progress one pixel wider
so it doesn't get swallowed by the focus outline.
Benjamin Otte [Sat, 16 Jan 2016 22:15:11 +0000 (23:15 +0100)]
stylechange: Do the right thing when old and new style are equal
We don't need to compare all their CSS values to figure out that nothing
changed. We know that.
Benjamin Otte [Sat, 16 Jan 2016 03:55:58 +0000 (04:55 +0100)]
cssnode: Redo GTK_DEBUG=no-css-cache
Previously this setting would just invalidate the whole CSS tree and
thereby hopefully avoid all cache usage.
Now, we actually don't cause extra invalidations anymore, but instead
avoid ever inserting anything into the cache when this setting is set.
Benjamin Otte [Sat, 16 Jan 2016 03:48:58 +0000 (04:48 +0100)]
cssnode: Implement the style cache
This essentially copies the previous cache implementation. With one
caveat: It is now attached to and maintained by the CssNode, not by the
CssStyle.
And this is important because styles may be reused in incompatible
situations which would cause cache collisions and lead to broken CSS in
weird situations.
Benjamin Otte [Fri, 15 Jan 2016 22:27:51 +0000 (23:27 +0100)]
cssnode: Split out the style cache
For now, the split out style cache doesn't cache anything. This is
mostly to make sure that bisections of wrong caching behavior will
bisect down to the commit that actually adds caching.
Lapo Calamandrei [Sat, 16 Jan 2016 03:16:55 +0000 (04:16 +0100)]
Adwaita: stop axing toolbar separators
Lapo Calamandrei [Sat, 16 Jan 2016 03:15:30 +0000 (04:15 +0100)]
Adwaita: style textview derived widgets
Matthias Clasen [Sat, 16 Jan 2016 01:08:57 +0000 (20:08 -0500)]
color scale: Improve themability
Add the .color class, so themes can style scale.color.
Clip the trough rendering to the content path, so that
themes can set rounded corners.
Matthias Clasen [Sat, 16 Jan 2016 00:39:12 +0000 (19:39 -0500)]
treeview: Use foreground color to draw dnd marker
This is still not perfect, but makes the dnd marker better visible
in HighContrastInverse.
Matthias Clasen [Sat, 16 Jan 2016 00:11:03 +0000 (19:11 -0500)]
frame: Don't overlap label and child
We didn't do this previously, so don't start now.
https://bugzilla.gnome.org/show_bug.cgi?id=760528
Lapo Calamandrei [Fri, 15 Jan 2016 23:55:59 +0000 (00:55 +0100)]
Adwaita: combo style cleanup and fixes
fixes https://bugzilla.gnome.org/show_bug.cgi?id=760524
Matthias Clasen [Fri, 15 Jan 2016 22:55:44 +0000 (17:55 -0500)]
combo: Add .linked class when appropriate
Add the .linked style class to combo boxes which have
an entry, since that is what they are.
Matthias Clasen [Fri, 15 Jan 2016 22:47:08 +0000 (17:47 -0500)]
combobox: Document the popup window CSS node
Matthias Clasen [Fri, 15 Jan 2016 22:36:13 +0000 (17:36 -0500)]
application: Protect against double shutdown
It is not something that can happen normally.
But if it does, we shouldn't crash.
https://bugzilla.gnome.org/show_bug.cgi?id=760680
William Hua [Fri, 15 Jan 2016 19:09:33 +0000 (14:09 -0500)]
mir: add default GdkSeat for the default GdkDisplay
Matt Watson [Tue, 12 Jan 2016 02:40:53 +0000 (18:40 -0800)]
widget: remove queue_resize in set_sensitive
Calling gtk_widget_propagate_state is enough to queue a resize if
needed
See
da7a4089fe82981d1412aaa295e76d47a81ad6df
Rui Matos [Fri, 15 Jan 2016 17:35:25 +0000 (18:35 +0100)]
wayland: Fix an endless loop
Lapo Calamandrei [Fri, 15 Jan 2016 17:33:38 +0000 (18:33 +0100)]
Adwaita: remove messagedialog label squashing hack
since Matthias fixed this properly.
Matthias Clasen [Fri, 15 Jan 2016 16:58:51 +0000 (11:58 -0500)]
message dialog: Prevent empty title from being shown
We don't want to grow the titlebar by showing an empty label.
Lapo Calamandrei [Fri, 15 Jan 2016 16:56:49 +0000 (17:56 +0100)]
Adwaita: some dialog love
addresses https://bugzilla.gnome.org/show_bug.cgi?id=760525
Matthias Clasen [Fri, 15 Jan 2016 15:29:20 +0000 (10:29 -0500)]
expander: Destroy gadgets after child widgets
With child widgets now being sorted into box gadgets, bad things
happen if those gadgets disappear prematurely.
Benjamin Otte [Fri, 15 Jan 2016 11:58:14 +0000 (12:58 +0100)]
notebook: Destroy gadgets after chaining up
While chaining up, we might still call into the notebook code. And that
code expects the gadgets to be there.
https://bugzilla.gnome.org/show_bug.cgi?id=760640
Matthias Clasen [Fri, 15 Jan 2016 14:41:44 +0000 (09:41 -0500)]
expander: Convert to use box gadgets
Use a vertical box gadget for the overall expander, and a
horizontal one for the title row. This lets us get rid of
all the custom allocation code here.
Matthias Clasen [Fri, 15 Jan 2016 13:35:39 +0000 (08:35 -0500)]
expander: Deprecate spacing property
The same can be achieved with margins on the child, and
the spacing property gets in the way of converting the
expander to use box gadgets.
Matthias Clasen [Fri, 15 Jan 2016 11:47:31 +0000 (06:47 -0500)]
box gadget: Implement cross-axis alignment
So far, the box gadget is always allocating all children the
full size in the cross axis. This behavior corresponds to the
align-items: stretch behavior in
https://www.w3.org/TR/css-flexbox-1/#align-items-property
This commit implements the other modes described there.
While widgets have halign/valign properties that we can use for
this, the API for inserting gadgets has to change to take an
extra align parameter. All callers have been updated to pass
GTK_ALIGN_FILL, since that corresponds to the previous behavior.
https://bugzilla.gnome.org/show_bug.cgi?id=760668
Piotr Drąg [Fri, 15 Jan 2016 14:18:32 +0000 (15:18 +0100)]
Updated POTFILES.skip
Ignacio Casal Quinteiro [Fri, 15 Jan 2016 19:45:45 +0000 (11:45 -0800)]
win32: get rid of _gdk_screen global variable
The screen is part of the display so it should be belong to it.
Ignacio Casal Quinteiro [Fri, 15 Jan 2016 19:53:51 +0000 (11:53 -0800)]
win32: fix warning
Tom Schoonjans [Sun, 10 Jan 2016 04:07:07 +0000 (09:37 +0530)]
Windows library manager fix
The Makefile.am's had a dependency on incorrectly named libtool
archives for the generation of the .lib files.
https://bugzilla.gnome.org/show_bug.cgi?id=760388
Alberts Muktupāvels [Tue, 12 Jan 2016 19:34:56 +0000 (21:34 +0200)]
gtkwidgetpath: update gtk_widget_path_to_string
From gtk_widget_path_iter_set_object_name documentation:
"When set, the object name overrides the object type when matching CSS"
Update gtk_widget_path_to_string to match this behaviour.
Eric Williams [Wed, 13 Jan 2016 13:29:34 +0000 (08:29 -0500)]
Fix typo in previous documentation fix for gtk_css_provider_load_from_data()
Matthias Clasen [Thu, 14 Jan 2016 21:06:16 +0000 (16:06 -0500)]
Document -gtk-recolor syntax
Matthias Clasen [Thu, 14 Jan 2016 18:48:43 +0000 (13:48 -0500)]
Add a way to load recolored icons in CSS
This can come in handy to load images that are not in an icon theme,
but still benefit from symbolic recoloring.
https://bugzilla.gnome.org/show_bug.cgi?id=760536
Matthias Clasen [Thu, 14 Jan 2016 18:49:08 +0000 (13:49 -0500)]
icon theme: Export recoloring function
This will be used in subsequent commits.
https://bugzilla.gnome.org/show_bug.cgi?id=760536
Matthias Clasen [Thu, 14 Jan 2016 17:53:50 +0000 (12:53 -0500)]
icon theme: Add a way to create GtkIconInfos from files
This is sometimes needed, and calling into actual icon theme
code just for it is confusing - the resulting icon does not
depend on the icon theme at all.
https://bugzilla.gnome.org/show_bug.cgi?id=760536
Lapo Calamandrei [Thu, 14 Jan 2016 16:51:49 +0000 (17:51 +0100)]
Adwaita: pathbar style cleanup
Florian Müllner [Thu, 14 Jan 2016 13:45:28 +0000 (14:45 +0100)]
cssstyleproperty: Expose min-width/height
Lapo Calamandrei [Thu, 14 Jan 2016 15:26:22 +0000 (16:26 +0100)]
Adwaita: remove superfluous selector on keycap styling
now that keys are made directly with labels istead of frames.
Timm Bäder [Wed, 13 Jan 2016 18:24:46 +0000 (19:24 +0100)]
boxgadget: Don't use g_assert
Use g_return_if_fail instead so nothing abort()s.
Timm Bäder [Wed, 13 Jan 2016 18:14:33 +0000 (19:14 +0100)]
entry: Don't draw icons twice
Timm Bäder [Wed, 13 Jan 2016 18:11:24 +0000 (19:11 +0100)]
entry: Remove unused code
Timm Bäder [Wed, 13 Jan 2016 18:07:20 +0000 (19:07 +0100)]
label: Remove some unneeded conditionals
We are never passing NULL here.
Timm Bäder [Sat, 9 Jan 2016 16:15:29 +0000 (17:15 +0100)]
shortcutlabel: Use a label directly
We can everything we need without the frame around it now.
Руслан Ижбулатов [Sun, 27 Dec 2015 05:05:39 +0000 (05:05 +0000)]
GDK W32: Don't use WM-drawn shadow for tooltips
This prevents WM from drawing shadows around tooltip windows,
which, in Adwaita, should have no shadow and are CSD-ish (which means
that tooltip window is larger than it looks, and WM draws the shadow
only on the outside, leaving a gap between the visible tooltip edge and
the shadow).
https://bugzilla.gnome.org/show_bug.cgi?id=759898
Paolo Borelli [Thu, 17 Dec 2015 23:36:57 +0000 (00:36 +0100)]
win32: remove _gdk_root global variable
Руслан Ижбулатов [Thu, 14 Jan 2016 12:51:26 +0000 (12:51 +0000)]
Ensure that the fstat fix is not applied on x86_64
Matthias Clasen [Thu, 14 Jan 2016 12:33:04 +0000 (07:33 -0500)]
expander: center the arrow
In lieu of more sophisticated alignment, we need to at least
center the arrow allocation wrt to the label.
Руслан Ижбулатов [Thu, 14 Jan 2016 09:40:58 +0000 (09:40 +0000)]
W32: Ensure that correct statting function is used by iconcache
With Mingw-w64 fstat() can be an inline function that
calls _fstat32() or _fstat64(), depending on some macros.
And if LFS is enabled, fstat() is defined to turn into
_fstat32i64() or _fstat64(). And some/all of the above
might also be macros as well. Side-step all that mess
and excplicitly re-define fstat as _fstat32, which is
guaranteed to use a version of "stat" struct that
has 32-bit size and time fields, which is what we want.
https://bugzilla.gnome.org/show_bug.cgi?id=760615
Matthias Clasen [Thu, 14 Jan 2016 04:42:35 +0000 (23:42 -0500)]
font chooser: Add a CSS name
The CSS name for GtkFontChooserWidget is fontchooser.
Matthias Clasen [Thu, 14 Jan 2016 04:38:14 +0000 (23:38 -0500)]
app chooser: Set a CSS name
The CSS name for GtkAppChooserWidget is appchooser.
Matthias Clasen [Thu, 14 Jan 2016 04:37:08 +0000 (23:37 -0500)]
print dialog: Set a CSS name
The CSS name for GtkPrintUnixDialog is printdialog.
Matthias Clasen [Thu, 14 Jan 2016 04:35:22 +0000 (23:35 -0500)]
file chooser: Set a CSS name
The CSS name for GtkFileChooserWidget is ... filechooser.
Matthias Clasen [Thu, 14 Jan 2016 04:34:03 +0000 (23:34 -0500)]
color chooser: Set a CSS name
The CSS name for GtkColorChooserWidget is ... colorchooser.
Matthias Clasen [Thu, 14 Jan 2016 04:24:38 +0000 (23:24 -0500)]
inspector: Don't select 'randomly'
While rescanning the object tree, we were emitting ::object-selected
signals, possibly causing wild blinking in the application window.
Don't do that.
https://bugzilla.gnome.org/show_bug.cgi?id=760572
Matthias Clasen [Thu, 14 Jan 2016 04:06:32 +0000 (23:06 -0500)]
Expand CSS icon property docs a bit
Matthias Clasen [Thu, 14 Jan 2016 03:47:37 +0000 (22:47 -0500)]
Fix doc syntax
Matthias Clasen [Wed, 13 Jan 2016 21:25:41 +0000 (16:25 -0500)]
Improve docs for icon-related CSS properties
Clarify the relation between the various properties and the
icon loading functions.
Matthias Clasen [Wed, 13 Jan 2016 21:17:44 +0000 (16:17 -0500)]
Make -gtk-icontheme() use -gtk-icon-palette
This makes it possible to recolor themed icons with -gtk-icon-palette,
regardless whether they are loaded by the theme or the application.
Matthias Clasen [Wed, 13 Jan 2016 21:16:39 +0000 (16:16 -0500)]
Move the -gtk-icon-palette property up
Other properties will start depending on it in subsequent
commits, so move it up to prevent ordering problems.
Matthias Clasen [Wed, 13 Jan 2016 18:58:52 +0000 (13:58 -0500)]
color swatch: Use right allocation for window
Generally, input-only windows that correspond to CSS boxes
should be sized to the border allocation of the gadget.
Rafael Fontenelle [Wed, 13 Jan 2016 18:55:36 +0000 (18:55 +0000)]
Updated Brazilian Portuguese translation
Matthias Clasen [Wed, 13 Jan 2016 14:31:25 +0000 (09:31 -0500)]
Add css node tests for right-to-left levelbars
Cosimo Cecchi [Wed, 13 Jan 2016 16:30:02 +0000 (08:30 -0800)]
notebook: fix a GCC warning
Matthias Clasen [Wed, 13 Jan 2016 05:41:44 +0000 (00:41 -0500)]
Add css node tests for paned node ordering
Matthias Clasen [Wed, 13 Jan 2016 05:40:11 +0000 (00:40 -0500)]
paned: Update node ordering according to text direction
This was overlooked in the initial node conversion.
Matthias Clasen [Wed, 13 Jan 2016 05:39:53 +0000 (00:39 -0500)]
GtkBox: Documentation tweak
Matthias Clasen [Wed, 13 Jan 2016 05:26:48 +0000 (00:26 -0500)]
Update expected output of notebook css node test
The stack node is new.
Matthias Clasen [Wed, 13 Jan 2016 05:24:40 +0000 (00:24 -0500)]
notebook: Document the .dnd style class
We should aim to document all style classes that themes
can encounter during the normal operation of a widget.
Matthias Clasen [Wed, 13 Jan 2016 05:05:16 +0000 (00:05 -0500)]
Use convenience API that was introduced recently
Use gtk_css_gadget_set_state in all the places where we previously
were getting a node from a gadget, just to call gtk_css_node_set_state.
Matthias Clasen [Wed, 13 Jan 2016 05:01:14 +0000 (00:01 -0500)]
builtin icon: Don't save/restore cairo state
The reason why this was introduced is now handled in
gtk_css_stylke_render_icon since commit
0138af9f9684c0ec436b37e5962e9f82607d3ff8.
Matthias Clasen [Wed, 13 Jan 2016 04:57:35 +0000 (23:57 -0500)]
box gadget: Add some documentation
Matthias Clasen [Wed, 13 Jan 2016 04:40:28 +0000 (23:40 -0500)]
box: Document child node ordering
Dominique Leuenberger [Tue, 12 Jan 2016 08:29:00 +0000 (08:29 +0000)]
QEMU USB Tablet is not really a tablet - it's a trick
Unfortunately, Qemu gives us this confusing device to work with,
and the best we can do is filter it out based on its name.
https://bugzilla.gnome.org/show_bug.cgi?id=760445
Ting-Wei Lan [Mon, 11 Jan 2016 03:46:45 +0000 (11:46 +0800)]
broadway: Call setlocale in main function of broadwayd
It is required to correctly show translated messages on some locales.
https://bugzilla.gnome.org/show_bug.cgi?id=760416
Timm Bäder [Tue, 12 Jan 2016 20:37:27 +0000 (21:37 +0100)]
switch: Fix text positioning
https://bugzilla.gnome.org/show_bug.cgi?id=760509
Timm Bäder [Tue, 12 Jan 2016 20:36:37 +0000 (21:36 +0100)]
switch: Don't include margins in input window size
https://bugzilla.gnome.org/show_bug.cgi?id=760509
Timm Bäder [Tue, 12 Jan 2016 19:25:25 +0000 (20:25 +0100)]
modelbutton: Don't include margins in input window size
https://bugzilla.gnome.org/show_bug.cgi?id=760509
Timm Bäder [Tue, 12 Jan 2016 19:18:08 +0000 (20:18 +0100)]
button: Don't include margins in input window size
And do the same thing for GtkCheckButton
https://bugzilla.gnome.org/show_bug.cgi?id=760509
Timm Bäder [Fri, 8 Jan 2016 16:30:47 +0000 (17:30 +0100)]
entry: typo
Alberts Muktupāvels [Tue, 12 Jan 2016 07:51:26 +0000 (09:51 +0200)]
gdkseat: remove return from gdk_seat_ungrab
Timm Bäder [Tue, 12 Jan 2016 08:32:04 +0000 (09:32 +0100)]
Remove stray semicolon
Gets rid of a mixed code/declaration warning.
Matthias Clasen [Tue, 12 Jan 2016 04:20:26 +0000 (23:20 -0500)]
HighContrast: Fix selection in .views
Copy Adwaita fixes from
21a2fce8ba2a48fe3781e7a1f02b33e3a7bfd9ac.
Matthias Clasen [Tue, 12 Jan 2016 03:48:35 +0000 (22:48 -0500)]
Fix corner manipulation when growing rounded rects
This addresses problems with uneven border radius',
pointed out by Lapo.